Skip to content

Conversation

austinvazquez
Copy link

@austinvazquez austinvazquez commented Jul 3, 2025

Related to containerd/containerd/issues/12007

This change disables the custom fuzzers from github.com/AdamKorcz/instrumentation

This is to unblock changes in the containerd release/1.7 branch where the Go toolchain is older than the minimum requirement for the fuzzers in AdamKorcz/instrumentation.

Copy link

github-actions bot commented Jul 3, 2025

austinvazquez is a new contributor to projects/containerd. The PR must be approved by known contributors before it can be merged. The past contributors are: samuelkarp, kzys, cji

@AdamKorcz
Copy link
Collaborator

You need to remove these lines upstream first:

https://github.com/containerd/containerd/blob/5a8ab17048d99821fc72b9fe32e32d7a51ae075d/contrib/fuzz/oss_fuzz_build.sh#L41-L42

@austinvazquez
Copy link
Author

@AdamKorcz, I opened containerd/containerd#12059

I am thinking maybe we can pull the instrumentation repo if it does not exist and in the release/1.7 branch pin to a known good version pre-containerd 2.0 module or the Go mod version bump.

@AdamKorcz
Copy link
Collaborator

@AdamKorcz, I opened containerd/containerd#12059

I am thinking maybe we can pull the instrumentation repo if it does not exist and in the release/1.7 branch pin to a known good version pre-containerd 2.0 module or the Go mod version bump.

Sounds good. I can also update the instrumentation library, however, for getting the upstream CI running, I would just remove it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants